Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSAutoreleasePool improvements #31

Merged
merged 7 commits into from
Mar 4, 2024
Merged

NSAutoreleasePool improvements #31

merged 7 commits into from
Mar 4, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Feb 29, 2024

I guess this wasn't 100% ready for prime time yet, but it's hard to test this on Metal.jl without a release (now that we don't/can't commit Manifests anymore).

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 56.66667% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 72.30%. Comparing base (87af4dc) to head (6365c0e).

Files Patch % Lines
src/foundation.jl 56.66% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   73.23%   72.30%   -0.93%     
==========================================
  Files          10       10              
  Lines         736      762      +26     
==========================================
+ Hits          539      551      +12     
- Misses        197      211      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 51098b1 into master Mar 4, 2024
5 checks passed
@maleadt maleadt deleted the tb/autorelease branch March 4, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant