-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds libmsvcrt from mingw-64 to the build directory #57451
base: master
Are you sure you want to change the base?
Conversation
This seems to have fixed the build. I am not sure if this is a temporary fix or works more generally. Could the maintainers take a look and suggest changes (if any)? |
Can you elaborate what was the issue in the first place? |
…ded mingw lib path
@giordano I removed the hardcoded paths, and using |
okay the newest change might have broken the |
This does fix the build for 64bit but fails on mingw32 🥲 |
@giordano Is using |
Don't ask me, I don't use Windows, I have no clue 🙂 at least it's an environment variable which can be overridden. |
Maybe @vtjnash might know? |
We have the same line a couple lines higher, so this may just corrupt the build, depending on the compiler version in use. I am not sure the most reasonable fix here, since I've also run into those issues and use a similar patch to get around them |
The Problem: Build fails on Windows when using Msys/MinGW
Build was failing on windows 11 with MINGW64 using these instructions with the following error (See #57397). This is perhaps because of C runtime version mismatches (see #56840).
The fix
Copy the
libmsvcrt.a
provided bymingw
in the right spot in the julia build directory.this PR fixes it
based on this patch:
https://github.com/Zentrik/llvm_julia_tester/blob/d8bfc7590bbcb3a9bc5c9eedbfe11bf65eddd91c/julia-patches/ffba662dd275d1bdd5a5935f4d3cc372b5235d07
Fix #56840, fix #57397.