Add exit code to Base.compilecache error message
#57455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
approved these changes
Feb 18, 2025
|
CI failure is from |
kpamnany
added a commit
to RelationalAI/julia
that referenced
this pull request
Feb 18, 2025
Minor tweak to the error message: embed the exit code of the Julia child process that failed to compile the package.
3 tasks
vtjnash
reviewed
Feb 18, 2025
| @@ -3288,7 +3288,7 @@ function compilecache(pkg::PkgId, path::String, internal_stderr::IO = stderr, in | |||
| if p.exitcode == 125 | |||
| return PrecompilableError() | |||
| else | |||
| error("Failed to precompile $(repr("text/plain", pkg)) to $(repr(tmppath)).") | |||
There was a problem hiding this comment.
This seems like it could be a bit confusing?
julia> p = run(`./julia -e 'ccall(:jl_raise, Cvoid, (Cint,), 23)'`, wait=false); wait(p)
julia> p.exitcode
0
julia> Base.process_status(p)
"ProcessSignaled(2)"
There was a problem hiding this comment.
Ack. So what I want is to embed $(Base.process_status(p)) instead of just $(p.exitcode)?
kpamnany
added a commit
to RelationalAI/julia
that referenced
this pull request
Feb 18, 2025
…215) Minor tweak to the error message: embed the exit code of the Julia child process that failed to compile the package.
kpamnany
added a commit
that referenced
this pull request
Feb 18, 2025
kpamnany
added a commit
that referenced
this pull request
Feb 19, 2025
kpamnany
added a commit
to RelationalAI/julia
that referenced
this pull request
Feb 19, 2025
3 tasks
kpamnany
added a commit
to RelationalAI/julia
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweak to the error message: embed the exit code of the Julia child process that failed to compile the package.