Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement isolated system for AB (#32) #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement isolated system for AB (#32) #33

wants to merge 3 commits into from

Conversation

tjjarvinen
Copy link
Contributor

This implements isolated system support for AB. Only for 3D system, but that should be ok.

cortner
cortner requested changes Jan 11, 2025
View reviewed changes
Copy link
Member

@cortner cortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for creating this interface. Can you make one addition please : If the cell is an isolated system but not 3D, then print a human-readable error message?

@tjjarvinen
Copy link
Contributor Author

Done!

It now throws a standard error. It could also be DimensionMismatch, but that kinda implies two object with different dimensions, so not sure would it be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortner cortner cortner requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjjarvinen @cortner