Add support for commonjs module resolution #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execute tests as TS
seidelmartin
changed the title
|
Hi @JustinBeckwith, would you please check this PR or at least give some feedback? |
|
Greetings! While I appreciate the PR - I'm not really interested in adding dual CJS support. ES Modules have been out for quite some time, and many, many modules have moved towards ESM only. I'm not really looking for the additional testing and maintenance burden of dual support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this module is not importable in NodeJS applications that are using commonjs module resolution. In order to support them I've added a separate tsconfig file that builds not only ecmascript module but also commonjs module. The steps taken to support both approaches are described in https://www.sensedeep.com/blog/posts/2021/how-to-create-single-source-npm-module.html.
On top of that, I've also changed tests so they don't require to be built. I've added
ts-nodethat can be run together withmochaand tests can be run immediately.I believe it will resolve issues like #198 and #193