Merge pull request #86 from BinaryKitten/fix/remove_superfluous_check

Update Impersonate class for minor performance checks on each run/per row
KABBOUCHI · Jun 17, 2021 · e5aab84 · e5aab84
2 parents 8e67830 + cd5847c
commit e5aab84
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/Impersonate.php b/src/Impersonate.php
@@ -25,15 +25,16 @@ public function __construct($user = null)
 
         $this->exceptOnForms();
 
-        if (method_exists(auth()->user(), 'canImpersonate') && ! auth()->user()->canImpersonate()) {
+        $authUser = auth()->user();
+        if (method_exists($authUser, 'canImpersonate') && ! $authUser->canImpersonate()) {
             $this->component = null;
 
             return;
         }
 
-        if ($user != null) {
+        if ($user !== null) {
             if (is_numeric($user) || is_string($user)) {
-                $this->withMeta(['id' => $user instanceof Model ? $user->getKey() : $user]);
+                $this->withMeta(['id' => $user]);
             } else {
                 $user = $user instanceof Resource ? $user->resource : $user;