Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CriticalAlert component (#52) #99

Merged
merged 4 commits into from
Jan 12, 2025
Merged

feat: add CriticalAlert component (#52) #99

merged 4 commits into from
Jan 12, 2025

Conversation

Jeongyong-park
Copy link
Contributor

No description provided.

@lukasjhan lukasjhan linked an issue Dec 28, 2024 that may be closed by this pull request
긴급 공지 컴포넌트 제작 #52
Closed
lukasjhan
lukasjhan reviewed Dec 28, 2024
View reviewed changes
Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I got an error in CriticalAlert.stories.ts:4 when I start the storybook. Any idea why?

Internal server error: Failed to resolve import "@storybook/addon-viewport" from "stories/core/CriticalAlert.stories.ts". Does the file exist?

@lukasjhan
Copy link
Member

If viewport setup in parameters is removed, then it seems okay

@Jeongyong-park
Copy link
Contributor Author

If viewport setup in parameters is removed, then it seems okay

I removed that. review again pls

lukasjhan
lukasjhan reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me, plz resolve the comment, then we could merge this.

packages/core/lib/components/CriticalAlert.tsx Outdated Show resolved Hide resolved
@Jeongyong-park Jeongyong-park force-pushed the feat/critical-alert branch 2 times, most recently from 37d78de to 1547134 Compare January 8, 2025 04:58
lukasjhan
lukasjhan approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasjhan lukasjhan merged commit 01819c8 into KRDS-community:main Jan 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasjhan lukasjhan lukasjhan approved these changes

@hismethod hismethod Awaiting requested review from hismethod hismethod is a code owner

@yunseorim1116 yunseorim1116 Awaiting requested review from yunseorim1116 yunseorim1116 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

긴급 공지 컴포넌트 제작
2 participants
@Jeongyong-park @lukasjhan