kerosene-ui: Add boundaries for react-query integration #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhardy
force-pushed
the
feature/kerosene-ui-boundaries
branch
from
03051ab to
9bbba40
Compare
nhardy
force-pushed
the
feature/kerosene-ui-boundaries
branch
2 times, most recently
from
d69a39f to
2d2af9d
Compare
nhardy
force-pushed
the
feature/kerosene-ui-boundaries
branch
2 times, most recently
from
b25a4c7 to
552eb36
Compare
nhardy
force-pushed
the
feature/kerosene-ui-boundaries
branch
2 times, most recently
from
0e3e1f4 to
265450a
Compare
nhardy
commented
Dec 6, 2023
Comment on lines
-10
to
-11
| require("core-js/features/array/flat"); | ||
| require("core-js/features/array/flat-map"); |
There was a problem hiding this comment.
No longer required in the oldest supported Node LTS version
nhardy
commented
Dec 6, 2023
| @@ -7,5 +7,4 @@ require("@babel/register")({ | |||
| extensions: [".js", ".ts"], | |||
| }); | |||
|
|
|||
| require("core-js/features/array/flat"); | |||
| require("core-js/features/array/flat-map"); | |||
| require("core-js/features/promise/with-resolvers"); | |||
There was a problem hiding this comment.
Promise.withResolvers() not yet supported in Node or all browsers.
nhardy
commented
Dec 6, 2023
Comment on lines
+69
to
+72
| "@tanstack/react-query": { | ||
| "optional": true | ||
| }, | ||
| "react-error-boundary": { |
There was a problem hiding this comment.
Didn't want to introduce the requirement for @tanstack/react-query and react-error-boundary onto all consumers of @kablamo/kerosene-ui, so have included these as optional peer dependencies rather than creating a whole separate package for boundaries. This does mean though that any consumers that do have these dependencies will need to have compatible versions.
angusd3v
previously approved these changes
Dec 7, 2023
nhardy
force-pushed
the
feature/kerosene-ui-boundaries
branch
from
265450a to
be860a9
Compare
angusd3v
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.