Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config: Add autofix for type-only imports #131

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

nhardy
Copy link
Member

@nhardy nhardy commented Nov 22, 2023

Adds lint rules:

  • @typescript-eslint/consistent-type-imports - forces us to annotate type-only imports as such
  • @typescript-eslint/no-import-type-side-effects - forces an import with only type imports to have a top-level import type - if side effects are required, this should be specified with an explicit side effect import, e.g. import "path/to/side-effect";

Also replaces unmaintained babel-plugin-lodash

@nhardy nhardy requested a review from willdawsonme November 22, 2023 03:21
@coveralls
Copy link

Coverage Status

coverage: 82.059%. remained the same
when pulling 38742e7 on feature/eslint-config-type-only-import-autofix
into 057b748 on master.

Copy link
Contributor

@willdawsonme willdawsonme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nhardy nhardy merged commit c79dc2e into master Nov 22, 2023
4 checks passed
@nhardy nhardy deleted the feature/eslint-config-type-only-import-autofix branch November 22, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants