Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kerosene-ui: Fix React Query query helpers - isLoading -> isPending #134

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

nhardy
Copy link
Member

@nhardy nhardy commented Dec 10, 2023

These helpers were originally written for React Query v4, and I missed the rename of isLoading -> isPending, as isLoading was not removed but instead now represents something different. See React Query docs.

@nhardy nhardy requested a review from angusd3v December 10, 2023 23:23
@coveralls
Copy link

coveralls commented Dec 10, 2023

Coverage Status

coverage: 81.562%. remained the same
when pulling af4f135 on bugfix/kerosene-ui-query-boundary-helpers
into d9bfcb6 on master.

angusd3v
angusd3v previously approved these changes Dec 10, 2023
Copy link
Contributor

@angusd3v angusd3v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
nice one

@nhardy nhardy force-pushed the bugfix/kerosene-ui-query-boundary-helpers branch from 4c8ee74 to af4f135 Compare December 10, 2023 23:34
@nhardy nhardy merged commit 40e03d9 into master Dec 10, 2023
4 checks passed
@nhardy nhardy deleted the bugfix/kerosene-ui-query-boundary-helpers branch December 10, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants