Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clr.pattern(string, *colors) Magic Function #13

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

KennyOliver
Copy link
Owner

Finished Idea 1 in #7

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 10, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.31%.

Quality metrics Before After Change
Complexity 2.61 ⭐ 2.72 ⭐ 0.11 👎
Method Length 33.60 ⭐ 36.67 ⭐ 3.07 👎
Working memory 5.50 ⭐ 5.92 ⭐ 0.42 👎
Quality 84.45% 83.14% -1.31% 👎
Other metrics Before After Change
Lines 45 60 15
Changed files Quality Before Quality After Quality Change
VividHues/init.py 84.45% ⭐ 83.14% ⭐ -1.31% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@KennyOliver KennyOliver changed the title Pattern magic function Clr.pattern(string, *colors) Magic Function Dec 10, 2021
@KennyOliver KennyOliver merged commit c3abf51 into main Dec 10, 2021
@KennyOliver KennyOliver deleted the pattern-magic-function branch December 10, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant