Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider date-range as range filter in filter label #364

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

mattwcole
Copy link
Contributor

When setting column definition property filterVariant: "date-range" in combination with a custom filterFn, the filter icon and tooltip are incorrectly shown, even when no filter has been applied.

image

The filter label currently only displays properly if the filterFn is one of the built in values ['between', 'betweenInclusive', 'inNumberRange']. This change makes date-range always be considered as a range filter, regardless of the filter function.

The bug appears to exist in v2 also, I'd be happy to put up another PR if required.

Copy link

vercel bot commented Jun 21, 2024

@mattwcole is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@alessandrojcm
Copy link
Collaborator

Hi @mattwcole thanks for this. Yes please open a PR for v2 as well if you can.

@alessandrojcm alessandrojcm merged commit 63ee1f4 into KevinVandy:v1 Jul 10, 2024
0 of 3 checks passed
@mattwcole mattwcole deleted the date-range-filter-label-v1 branch July 17, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants