fix: 'reset' was not being passed to getDefaultColumnOrderIds #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reset order handler
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This potentially isn't necessarily what we want. I think this sets the state as an empty array |
|
Is this fixed? What version do I need for this? |
|
I'm not sure the proposed change is the fix. We may want to call our internal getDefaultColumnOrder until instead. |
So is the callback meant to call getDefaultColumnOrder instead of getDefaultColumnOrderIds? What is the expected result when you click the reset button? |
|
I'll test this more thoroughly tonight |
KevinVandy
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #384