Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use new KCL API #1067

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Update to use new KCL API #1067

merged 1 commit into from
Dec 5, 2024

Conversation

nrc
Copy link
Contributor

@nrc nrc commented Dec 5, 2024

No description provided.

@nrc nrc requested a review from greg-kcio December 5, 2024 19:13
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.18%. Comparing base (b87927e) to head (aa9ecc7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/iostreams.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1067      +/-   ##
==========================================
- Coverage   72.19%   72.18%   -0.02%     
==========================================
  Files          36       36              
  Lines        6640     6641       +1     
==========================================
  Hits         4794     4794              
- Misses       1846     1847       +1     
Flag Coverage Δ
unittests 72.18% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nick Cameron <[email protected]>
@greg-kcio
Copy link

adding Jess and Adam as reviewers since historically they maintain the CLI

@nrc nrc merged commit c2f53cf into main Dec 5, 2024
7 of 8 checks passed
@nrc nrc deleted the nrc-kcl-priv branch December 5, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants