Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new kcl lint subcommand #777

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Add a new kcl lint subcommand #777

merged 3 commits into from
Jul 29, 2024

Conversation

paultag
Copy link
Contributor

@paultag paultag commented Jul 29, 2024

This will allow us to run the linter (as seen in the LSP and ZMA) locally using the zoo CLI.

This will allow us to run the linter (as seen in the LSP and ZMA)
locally using the zoo CLI.

Signed-off-by: Paul R. Tagliamonte <[email protected]>
src/cmd_kcl.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 32 lines in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (c0760fb) to head (1a92936).
Report is 4 commits behind head on main.

Files Patch % Lines
src/cmd_kcl.rs 49.20% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #777      +/-   ##
==========================================
- Coverage   78.07%   77.87%   -0.20%     
==========================================
  Files          36       36              
  Lines        7652     7728      +76     
==========================================
+ Hits         5974     6018      +44     
- Misses       1678     1710      +32     
Flag Coverage Δ
unittests 77.87% <57.89%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz
Copy link
Contributor

sorry to be a pain but a test would be nice here: https://github.com/KittyCAD/cli/blob/main/src/tests.rs#L592 😇

@paultag paultag requested a review from jessfraz July 29, 2024 19:24
@jessfraz
Copy link
Contributor

woohoo perfect

@jessfraz jessfraz merged commit da23619 into main Jul 29, 2024
7 of 8 checks passed
@jessfraz jessfraz deleted the paultag/lint branch July 29, 2024 19:34
@jessfraz
Copy link
Contributor

im gunna push a new kcl-lib in a bit so ill bump this and release then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants