Fix switching between KCL arguments (#5512)

* Fix switching between KCL arguments Needed to imperatively send a transaction to the editor, since it doesn't get re-rendered when switching from one KCL-type arg to another. * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Pierre Jacquier <[email protected]>
KittyCAD · Feb 27, 2025 · da236d9 · da236d9
1 parent 1104d90
commit da236d9
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 3 deletions.
diff --git a/...tests.spec.ts-snapshots/Sketch-on-face-with-none-z-up-1-Google-Chrome-linux.png b/...tests.spec.ts-snapshots/Sketch-on-face-with-none-z-up-1-Google-Chrome-linux.png
diff --git a/...spec.ts-snapshots/code-color-goober-code-color-goober-1-Google-Chrome-linux.png b/...spec.ts-snapshots/code-color-goober-code-color-goober-1-Google-Chrome-linux.png
diff --git a/...pshots/extrude-on-default-planes-should-be-stable--XZ-1-Google-Chrome-linux.png b/...pshots/extrude-on-default-planes-should-be-stable--XZ-1-Google-Chrome-linux.png
diff --git a/...apshots/extrude-on-default-planes-should-be-stable-XZ-1-Google-Chrome-linux.png b/...apshots/extrude-on-default-planes-should-be-stable-XZ-1-Google-Chrome-linux.png
diff --git a/src/components/CommandBar/CommandBarKclInput.tsx b/src/components/CommandBar/CommandBarKclInput.tsx
@@ -74,9 +74,11 @@ function CommandBarKclInput({
     arg.name,
     previouslySetValue,
   ])
-  const [value, setValue] = useState(
-    previouslySetValue?.valueText || defaultValue || ''
+  const initialValue = useMemo(
+    () => previouslySetValue?.valueText || defaultValue || '',
+    [previouslySetValue, defaultValue]
   )
+  const [value, setValue] = useState(initialValue)
   const [createNewVariable, setCreateNewVariable] = useState(
     (previouslySetValue && 'variableName' in previouslySetValue) ||
       arg.createVariableByDefault ||
@@ -105,7 +107,7 @@ function CommandBarKclInput({
   }))
   const varMentionsExtension = varMentions(varMentionData)
 
-  const { setContainer } = useCodeMirror({
+  const { setContainer, view } = useCodeMirror({
     container: editorRef.current,
     initialDocValue: value,
     autoFocus: true,
@@ -161,6 +163,21 @@ function CommandBarKclInput({
   useEffect(() => {
     if (editorRef.current) {
       setContainer(editorRef.current)
+      // Reset the value when the arg changes and
+      // the new arg is also a KCL type, since the component
+      // sticks around.
+      view?.focus()
+      view?.dispatch({
+        changes: {
+          from: 0,
+          to: view.state.doc.length,
+          insert: initialValue,
+        },
+        selection: {
+          anchor: 0,
+          head: initialValue.length,
+        },
+      })
     }
   }, [arg, editorRef])