Skip to content

Commit

Permalink
Rust: Remove iai benchmark tests
Browse files Browse the repository at this point in the history
We don't get much value from these, we can always run criterion or valgrind locally.

If we want to measure instruction counts, we should be using codspeed.io instead because
they support visualizing and tracking over time.

If we want to track performance over time we should be using Kevin's perf monitor machine.
  • Loading branch information
adamchalmers committed Jan 17, 2025
1 parent 0592d3b commit ddf0012
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 127 deletions.
7 changes: 0 additions & 7 deletions src/wasm-lib/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 0 additions & 13 deletions src/wasm-lib/kcl/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ base64 = "0.22.1"
criterion = { version = "0.5.1", features = ["async_tokio"] }
expectorate = "1.1.0"
handlebars = "6.3.0"
iai = "0.1"
image = { version = "0.25.5", default-features = false, features = ["png"] }
insta = { version = "1.41.1", features = ["json", "filters", "redactions"] }
itertools = "0.13.0"
Expand All @@ -129,10 +128,6 @@ workspace = true
name = "compiler_benchmark_criterion"
harness = false

[[bench]]
name = "compiler_benchmark_iai"
harness = false

[[bench]]
name = "digest_benchmark"
harness = false
Expand All @@ -142,15 +137,7 @@ name = "lsp_semantic_tokens_benchmark_criterion"
harness = false
required-features = ["lsp-test-util"]

[[bench]]
name = "lsp_semantic_tokens_benchmark_iai"
harness = false
required-features = ["lsp-test-util"]

[[bench]]
name = "executor_benchmark_criterion"
harness = false

[[bench]]
name = "executor_benchmark_iai"
harness = false
35 changes: 0 additions & 35 deletions src/wasm-lib/kcl/benches/compiler_benchmark_iai.rs

This file was deleted.

27 changes: 0 additions & 27 deletions src/wasm-lib/kcl/benches/executor_benchmark_iai.rs

This file was deleted.

45 changes: 0 additions & 45 deletions src/wasm-lib/kcl/benches/lsp_semantic_tokens_benchmark_iai.rs

This file was deleted.

0 comments on commit ddf0012

Please sign in to comment.