Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double export regression test #3756

Closed
wants to merge 11 commits into from
Closed

Fix double export regression test #3756

wants to merge 11 commits into from

Conversation

Irev-Dev
Copy link
Collaborator

@Irev-Dev Irev-Dev commented Sep 3, 2024

remove the || TEST logic.

Note I need to change the target to franknoirot/fix-electron-playwright, but some tests don't run unless pointed at main, and I want to sanity check I didn't break other tests by removing || TEST

The actually diff is this commit d4b73dc

Copy link

qa-wolf bot commented Sep 3, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Sep 4, 2024 1:13am

Copy link
Contributor

github-actions bot commented Sep 3, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@Irev-Dev Irev-Dev force-pushed the kurt-remove-or-TEST branch from 30fef6c to 4d10d11 Compare September 4, 2024 00:13
Copy link
Contributor

github-actions bot commented Sep 4, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants