KCL: Look straight ahead on startup #4657
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The engine used to look straight ahead when it started. Recently it changed to an isometric viewpoint. While this looks nice, the frontend team needs time to adjust tests which assumed the old viewpoint. So, temporarily ensure the old view is set at the start.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franknoirot
reviewed
Dec 4, 2024
There was a problem hiding this comment.
I'm not sure why, but the gizmo still seems to be picking up the new initial vantage from the engine. Maybe this will only need a small fix
There was a problem hiding this comment.
But I don't think it should block personally?
|
This PR is now managed by Frank |
|
Do we still need this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine used to look straight ahead when it started. Recently it changed to an isometric viewpoint. While this looks nice, the frontend team needs time to adjust tests which assumed the old viewpoint.
So, temporarily ensure the old view is set at the start.