Minor bits and pieces #5066
Merged
Minor bits and pieces #5066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5066 +/- ##
==========================================
- Coverage 86.00% 85.99% -0.02%
==========================================
Files 88 88
Lines 31493 31470 -23
==========================================
- Hits 27085 27062 -23
Misses 4408 4408
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jtran
approved these changes
Jan 15, 2025
Signed-off-by: Nick Cameron <[email protected]>
…cess Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
TomPridham
pushed a commit
to TomPridham/modeling-app
that referenced
this pull request
Feb 13, 2025
* Use std deprecation for int rather than a hack in the parser Signed-off-by: Nick Cameron <[email protected]> * Don't allow an epsilon when converting floats to ints for property access Signed-off-by: Nick Cameron <[email protected]> * Fixup tests Signed-off-by: Nick Cameron <[email protected]> --------- Signed-off-by: Nick Cameron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor fixups:
intfunction, rather than a hack in the parser