Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform std lib functions #5067

Merged
merged 11 commits into from
Feb 27, 2025
Merged

Transform std lib functions #5067

merged 11 commits into from
Feb 27, 2025

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Jan 14, 2025

  • more examples of local axis stuff
  • translate needs to be length units so the units dont get messed up
  • fix the bugs where scale and other fn names were used elsewhere and now causing errors

design decisions:

  • josh said MEs would be more used to everything being on the local axis by default
  • josh said everything should be relative, meaning if you scale by 25% once then do it again, its scaled twice not once by 25%
  • also if you move by (2, 0, 0) and you started at (4,0,0) you are now at (6,0,0)
  • this reflects the defaults i chose

Copy link

qa-wolf bot commented Jan 14, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 27, 2025 0:01am

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 97.13656% with 13 lines in your changes missing coverage. Please review.

Project coverage is 86.45%. Comparing base (91f5465) to head (b2326c4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/std/transform.rs 96.96% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5067      +/-   ##
==========================================
+ Coverage   86.35%   86.45%   +0.10%     
==========================================
  Files          95       96       +1     
  Lines       36020    36473     +453     
==========================================
+ Hits        31104    31533     +429     
- Misses       4916     4940      +24     
Flag Coverage Δ
wasm-lib 86.45% <97.13%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Copy link
Collaborator

@jgomez720 jgomez720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this looks great.

@jessfraz jessfraz merged commit 56e100f into main Feb 27, 2025
37 checks passed
@jessfraz jessfraz deleted the transform branch February 27, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support assemblies in KCL
2 participants