Add units to geometry structs #5075
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
nrc
force-pushed
the
nrc-uom-geom
branch
2 times, most recently
from
1397dfb to
edf3372
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5075 +/- ##
==========================================
+ Coverage 86.09% 86.15% +0.06%
==========================================
Files 89 89
Lines 32389 32450 +61
==========================================
+ Hits 27884 27958 +74
+ Misses 4505 4492 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -854,6 +862,7 @@ impl Plane { | |||
| y_axis: *y_axis, | |||
| z_axis: *z_axis, | |||
| value: PlaneType::Custom, | |||
| units: exec_state.length_unit(), | |||
There was a problem hiding this comment.
Hmm, you can't specify the units on the coordinates themselves, huh? Is the next step in the units plan to allow this? Unclear to me how this will all work together, but I trust you that you'll figure it out.
There was a problem hiding this comment.
Yeah, one of the next steps is to add units to floats and coords etc
There was a problem hiding this comment.
It's a really huge, messy PR so I'm picking off any bits that are relatively self-contained like this
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
* Make all geometry KclValue variants into struct variants Signed-off-by: Nick Cameron <[email protected]> * Add units to geometry types Signed-off-by: Nick Cameron <[email protected]> --------- Signed-off-by: Nick Cameron <[email protected]>
The first commit is a refactoring which I didn't end up needing, but I think is worth keeping and was a fair amount of work. The second commit actually adds units to geometry (part of the units of measure work).