Add building the artifact graph in sketch mode #5093
Draft
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
Base automatically changed from
jtran/rust-artifact-graph-episode-ii-ferris-strikes-back
to
main
January 17, 2025 19:34
jtran
force-pushed
the
jtran/sketch-mode-artifact-graph
branch
from
8103277 to
c21e316
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5093 +/- ##
=======================================
Coverage 86.08% 86.09%
=======================================
Files 89 89
Lines 32538 32542 +4
=======================================
+ Hits 28011 28017 +6
+ Misses 4527 4525 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jtran
force-pushed
the
jtran/sketch-mode-artifact-graph
branch
from
c21e316 to
c69084d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5166. Depends on #5068.
Proof of concept. Not sure what this breaks. I verified that the graph gets built without exiting sketch mode. The Debug Pane doesn't update though.