ci: Fix panic in cargo bench job #5099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
force-pushed
the
jtran/fix-ci-cargo-bench
branch
3 times, most recently
from
d8fd58b to
db3a71b
Compare
jtran
force-pushed
the
jtran/fix-ci-cargo-bench
branch
from
9ac2678 to
6a17feb
Compare
Merged
|
Honestly we can probably just kill the iai integration instead. I don't think anyone ever checks it and it's not really adding much value. We can run criterion manually on our machines, and we collect performance data from Kevin's test machine. WDYT? Here's a PR to do just that: #5102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to downgrade valgrind. To do that, I downgraded to Ubuntu 22.04. This might be slower since it's no longer using the 8 core runner. But at least it runs now.
See bheisler/iai#34.