-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Shell dry-run validation with thickness arg #5118
base: main
Are you sure you want to change the base?
WIP: Shell dry-run validation with thickness arg #5118
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
1 similar comment
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5118 +/- ##
=======================================
Coverage 86.14% 86.14%
=======================================
Files 89 89
Lines 32489 32489
=======================================
Hits 27987 27987
Misses 4502 4502
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ions-and-extra-arguments
Yeah this is a good idea within the command bar. Since the user provides these values step by step, it makes sense to help them from shooting themselves in their foot. |
@nadr0 I was playing with this today. Moves the shell validation to the last argument (thickness) so we can run it on provided selections and thickness. Maybe this workflow could become the default one for the review stage of the command bar process. Or evolve into something else. But I figured this wasn't the only command that it could be useful for. Let me know if you have any thoughts