Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating onboarding bracket with SSI #5281

Merged
merged 18 commits into from
Feb 6, 2025
Merged

Conversation

jgomez720
Copy link
Collaborator

No description provided.

Copy link

qa-wolf bot commented Feb 5, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 6, 2025 3:59pm

Copy link
Contributor

github-actions bot commented Feb 5, 2025

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Collaborator

@pierremtb pierremtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.05%. Comparing base (e0de049) to head (de5dbd1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5281   +/-   ##
=======================================
  Coverage   86.05%   86.05%           
=======================================
  Files          92       92           
  Lines       33204    33204           
=======================================
  Hits        28575    28575           
  Misses       4629     4629           
Flag Coverage Δ
wasm-lib 86.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jtran and others added 3 commits February 5, 2025 18:32
* Upgrade rust toolchain to 1.84.1

* Fix lint warnings
…5238)

* Fix to invalidate cache when top-level annotations change

* Change to BTreeMap to allow deterministic iteration

* Fix execution cache to look at annotations
Copy link
Contributor

github-actions bot commented Feb 6, 2025

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@pierremtb
Copy link
Collaborator

I actually think this test failure zoo-test.ts:86:10 › Regression tests › when engine fails export we handle the failure and alert the user @skipWin might be real?

The windows one is about text-to-cad has been happening since yesterday, created #5286 to disable it on windows as it's been unreliable and we already have coverage.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@pierremtb pierremtb merged commit c8653be into main Feb 6, 2025
30 checks passed
@pierremtb pierremtb deleted the josh-update-onboarding-ssi branch February 6, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants