KCL: Linear/circular pattern in stdlib should use kwargs #5315

adamchalmers · 2025-02-07T23:23:29Z

No description provided.

qa-wolf · 2025-02-07T23:23:32Z

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

vercel · 2025-02-07T23:23:34Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
modeling-app	✅ Ready (Inspect)	Visit Preview	Feb 11, 2025 9:54pm

github-actions · 2025-02-07T23:27:04Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-07T23:33:23Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-10T15:32:14Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-10T17:43:09Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-10T21:33:44Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-10T22:05:35Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-10T22:56:52Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-10T23:07:36Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-10T23:20:16Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-10T23:37:47Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T00:14:47Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T00:26:01Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T00:37:16Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T00:48:50Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

codecov · 2025-02-11T15:04:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.75%. Comparing base (10b7a77) to head (cf8f311).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5315      +/-   ##
==========================================
- Coverage   85.80%   85.75%   -0.06%     
==========================================
  Files          94       94              
  Lines       33554    34247     +693     
==========================================
+ Hits        28792    29368     +576     
- Misses       4762     4879     +117

Flag	Coverage Δ
wasm-lib	`85.75% <100.00%> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jtran · 2025-02-11T15:28:11Z

src/wasm-lib/justfile

+    EXPECTORATE=overwrite {{cita}} -p kcl-lib -- simulation_tests::{{test_name}}::parse
+    EXPECTORATE=overwrite {{cita}} -p kcl-lib -- simulation_tests::{{test_name}}::unparse


Should we update the run command? Do you ever not want to overwrite?

src/wasm-lib/kcl/src/std/patterns.rs

src/wasm-lib/kcl/src/unparser.rs

github-actions · 2025-02-11T16:10:07Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T16:35:17Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T16:42:01Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T16:44:27Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T16:51:36Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T17:35:08Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T17:46:30Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T18:01:57Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T20:40:58Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2025-02-11T20:41:44Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

…u-8-cores)

github-actions · 2025-02-11T20:54:52Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

…u-8-cores)

github-actions · 2025-02-11T21:06:23Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

…u-8-cores)

github-actions · 2025-02-11T21:20:50Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

…u-8-cores)

github-actions · 2025-02-11T21:32:56Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

adamchalmers force-pushed the achalmers/kw-pattern branch from 1090834 to 6dbb914 Compare February 7, 2025 23:26

vercel bot deployed to Preview February 7, 2025 23:45 View deployment

vercel bot deployed to Preview February 10, 2025 15:42 View deployment

adamchalmers force-pushed the achalmers/kw-pattern branch from 41242a2 to 501c053 Compare February 10, 2025 17:42

vercel bot deployed to Preview February 10, 2025 17:55 View deployment

vercel bot deployed to Preview February 10, 2025 21:45 View deployment

adamchalmers marked this pull request as ready for review February 10, 2025 22:07

vercel bot deployed to Preview February 10, 2025 22:17 View deployment

adamchalmers force-pushed the achalmers/kw-pattern branch from 3803a2f to ac69b12 Compare February 10, 2025 22:56

vercel bot deployed to Preview February 10, 2025 23:33 View deployment

vercel bot deployed to Preview February 10, 2025 23:49 View deployment

adamchalmers changed the title ~~KCL: Pattern stdlib functions should use kwargs~~ KCL: Linear/circular pattern in stdlib should use kwargs Feb 11, 2025

vercel bot deployed to Preview February 11, 2025 01:03 View deployment

jtran approved these changes Feb 11, 2025

View reviewed changes

vercel bot deployed to Preview February 11, 2025 16:22 View deployment

adamchalmers force-pushed the achalmers/kw-pattern branch from e611e78 to 41d1913 Compare February 11, 2025 16:35

vercel bot deployed to Preview February 11, 2025 17:11 View deployment

vercel bot deployed to Preview February 11, 2025 17:59 View deployment

vercel bot deployed to Preview February 11, 2025 18:14 View deployment

adamchalmers force-pushed the achalmers/kw-pattern branch from c48a8c5 to 807264e Compare February 11, 2025 20:40

KCL: Linear/circular pattern in stdlib should use kwargs

5163638

adamchalmers force-pushed the achalmers/kw-pattern branch from 807264e to 5163638 Compare February 11, 2025 20:41

A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…

efa33b3

…u-8-cores)

A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…

342b3c0

…u-8-cores)

A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…

950739a

…u-8-cores)

A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…

cf8f311

…u-8-cores)

vercel bot deployed to Preview February 11, 2025 21:54 View deployment

adamchalmers merged commit c68e5d7 into main Feb 11, 2025
38 checks passed

adamchalmers deleted the achalmers/kw-pattern branch February 11, 2025 22:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KCL: Linear/circular pattern in stdlib should use kwargs #5315

KCL: Linear/circular pattern in stdlib should use kwargs #5315

adamchalmers commented Feb 7, 2025

qa-wolf bot commented Feb 7, 2025

vercel bot commented Feb 7, 2025 •

edited

Loading

github-actions bot commented Feb 7, 2025

github-actions bot commented Feb 7, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

codecov bot commented Feb 11, 2025 •

edited

Loading

jtran Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

		EXPECTORATE=overwrite {{cita}} -p kcl-lib -- simulation_tests::{{test_name}}::parse
		EXPECTORATE=overwrite {{cita}} -p kcl-lib -- simulation_tests::{{test_name}}::unparse

KCL: Linear/circular pattern in stdlib should use kwargs #5315

KCL: Linear/circular pattern in stdlib should use kwargs #5315

Conversation

adamchalmers commented Feb 7, 2025

qa-wolf bot commented Feb 7, 2025

vercel bot commented Feb 7, 2025 • edited Loading

github-actions bot commented Feb 7, 2025

github-actions bot commented Feb 7, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

codecov bot commented Feb 11, 2025 • edited Loading

Codecov Report

jtran Feb 11, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

vercel bot commented Feb 7, 2025 •

edited

Loading

codecov bot commented Feb 11, 2025 •

edited

Loading