WIP: Pin kcl-samples to a commit sha #5357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
jtran
approved these changes
Feb 12, 2025
pierremtb
commented
Feb 12, 2025
| @@ -85,7 +85,7 @@ | |||
| "fmt": "prettier --write ./src *.ts *.json *.js ./e2e ./packages", | |||
| "fmt-check": "prettier --check ./src *.ts *.json *.js ./e2e ./packages", | |||
| "fetch:wasm": "./get-latest-wasm-bundle.sh", | |||
| "fetch:samples": "echo \"Fetching latest KCL samples...\" && curl -o public/kcl-samples-manifest-fallback.json https://raw.githubusercontent.com/KittyCAD/kcl-samples/achalmers/kw-pattern/manifest.json", | |||
| "fetch:samples": "echo \"Fetching latest KCL samples...\" && curl -o public/kcl-samples-manifest-fallback.json https://raw.githubusercontent.com/KittyCAD/kcl-samples/4fef4c34805322272ffb9486e524203ba0d78c1d/manifest.json", | |||
There was a problem hiding this comment.
Need to find a way to make this read .env.development. Source failed on win so I reverted it for now
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5357 +/- ##
=======================================
Coverage 85.89% 85.89%
=======================================
Files 94 94
Lines 34523 34523
=======================================
Hits 29653 29653
Misses 4870 4870
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pierremtb
changed the title
|
Will be covered by #5460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we don't carry this in all PRsChange of plans: we're going to pin kcl-samples to a version now, and eventually make it a npm package that can be dependabot auto updated.