Make nightly builds tag-based to allow manual triggering #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pierremtb
changed the title
|
Waiting on #5490 to mark it as ready |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5493 +/- ##
=======================================
Coverage 86.26% 86.26%
=======================================
Files 95 95
Lines 35901 35901
=======================================
Hits 30970 30970
Misses 4931 4931
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…sed-so-that-new-ones-can-be-published-on-demand
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pierremtb
changed the title
pierremtb
commented
Feb 25, 2025
Comment on lines
+34
to
+35
| VERSION_NO_V=$(date +'%-y.%-m.%-d') | ||
| TAG="nightly-v$VERSION_NO_V" |
There was a problem hiding this comment.
As per @nadr0 this could be turned into a helper script that one could run locally
nadr0
approved these changes
Feb 25, 2025
pierremtb
deleted the
pierremtb/issue5492-Make-nightly-runs-tag-based-so-that-new-ones-can-be-published-on-demand
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5492
tag-nightly.ymlis the new workflow here, waiting on cron triggers to simple push a new nighly tag out. Since this is thru an app token, this should (to be tested) triggerbuild-apps.yml, which is updated to work withnightly-vtags. Not touching the publishing part yet to keep it scoped as low as possible. Eventually it will be good to have release and nightly go through the same upload and publish workflow, see #5495