Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kcl-samples URL and other minor things #5508

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

jtran
Copy link
Collaborator

@jtran jtran commented Feb 25, 2025

The extra files are from #5389 (comment).

@jtran jtran requested a review from adamchalmers February 25, 2025 20:22
Copy link

qa-wolf bot commented Feb 25, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 25, 2025 8:34pm

@jtran jtran merged commit ded97ed into main Feb 25, 2025
33 checks passed
@jtran jtran deleted the jtran/fix-samples-url branch February 25, 2025 20:54
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.29%. Comparing base (f6b0652) to head (e056839).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5508   +/-   ##
=======================================
  Coverage   86.29%   86.29%           
=======================================
  Files          95       95           
  Lines       35941    35941           
=======================================
  Hits        31014    31014           
  Misses       4927     4927           
Flag Coverage Δ
wasm-lib 86.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants