Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make memory accessible from multiple threads/tasks #5530

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

nrc
Copy link
Contributor

@nrc nrc commented Feb 26, 2025

Factors out a Stack from ProgramMemory which encapsulates a call stack for a module. Multiple Stacks on different threads share a single ProgramMemory which means memory does not need to be reassembled after evaluating a module.

@nrc nrc requested review from jtran and adamchalmers February 26, 2025 20:43
Copy link

qa-wolf bot commented Feb 26, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 28, 2025 4:30am

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 95.55556% with 22 lines in your changes missing coverage. Please review.

Project coverage is 86.58%. Comparing base (b31786c) to head (3506bec).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/execution/memory.rs 95.41% 18 Missing ⚠️
src/wasm-lib/kcl/src/execution/mod.rs 93.10% 2 Missing ⚠️
src/wasm-lib/kcl/src/execution/exec_ast.rs 98.24% 1 Missing ⚠️
src/wasm-lib/kcl/src/std/args.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5530      +/-   ##
==========================================
+ Coverage   86.41%   86.58%   +0.16%     
==========================================
  Files          97       97              
  Lines       37194    37431     +237     
==========================================
+ Hits        32143    32411     +268     
+ Misses       5051     5020      -31     
Flag Coverage Δ
wasm-lib 86.58% <95.55%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants