Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hover tool tips and function docs #5538

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Improve hover tool tips and function docs #5538

merged 3 commits into from
Feb 27, 2025

Conversation

nrc
Copy link
Contributor

@nrc nrc commented Feb 27, 2025

The big change is that function signatures are formatted in the markdown docs and for tooltips. I've also fixed some dodgy markdown and added a little padding.

Before:
Screenshot 2025-02-27 at 4 37 35 PM

After:
Screenshot 2025-02-27 at 4 24 54 PM

Copy link

qa-wolf bot commented Feb 27, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 27, 2025 8:41am

@nrc nrc requested review from jessfraz, adamchalmers and jtran and removed request for jessfraz and adamchalmers February 27, 2025 03:41
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (8d9bba0) to head (e1217b2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5538      +/-   ##
==========================================
- Coverage   86.51%   86.41%   -0.10%     
==========================================
  Files          97       97              
  Lines       36623    37194     +571     
==========================================
+ Hits        31684    32143     +459     
- Misses       4939     5051     +112     
Flag Coverage Δ
wasm-lib 86.41% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nrc nrc merged commit 1104d90 into main Feb 27, 2025
36 of 37 checks passed
@nrc nrc deleted the nrc-hover-md branch February 27, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants