Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hole from toolbar #5543

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

pierremtb
Copy link
Collaborator

Fixes #5542

Copy link

qa-wolf bot commented Feb 27, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 27, 2025 1:29pm

Copy link
Collaborator Author

@pierremtb pierremtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will put to ready once we have the updated snapshots

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (da236d9) to head (3c89e13).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5543   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files          97       97           
  Lines       37194    37194           
=======================================
  Hits        32143    32143           
  Misses       5051     5051           
Flag Coverage Δ
wasm-lib 86.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierremtb pierremtb marked this pull request as ready for review February 27, 2025 13:58
Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks

@pierremtb pierremtb merged commit 02c2e80 into main Feb 27, 2025
35 checks passed
@pierremtb pierremtb deleted the pierremtb/issue5542-Remove-hole-from-toolbar branch February 27, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hole from toolbar
2 participants