Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to E2E test to verify Backspace doesn't dismiss command palette #5557

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

franknoirot
Copy link
Collaborator

Closes #5007.

Copy link

qa-wolf bot commented Feb 27, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 27, 2025 6:39pm

Copy link
Collaborator

@pierremtb pierremtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beauty

@pierremtb pierremtb enabled auto-merge (squash) February 27, 2025 18:43
@pierremtb pierremtb merged commit b31786c into main Feb 27, 2025
33 checks passed
@pierremtb pierremtb deleted the franknoirot/5007/test-cmdbar-backspace branch February 27, 2025 18:58
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (936549d) to head (52a2028).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5557   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files          97       97           
  Lines       37194    37194           
=======================================
  Hits        32143    32143           
  Misses       5051     5051           
Flag Coverage Δ
wasm-lib 86.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backspace should not remove geometry
2 participants