Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow in KCL command palette input #5559

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

franknoirot
Copy link
Collaborator

Closes #4719.

Looks much better now I think, yeah?

Screenshare.-.2025-02-27.2_17_28.PM-compressed.mp4

@franknoirot franknoirot requested a review from a team February 27, 2025 19:18
Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 27, 2025 7:28pm

Copy link

qa-wolf bot commented Feb 27, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (b31786c) to head (0478a54).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5559   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files          97       97           
  Lines       37194    37194           
=======================================
  Hits        32143    32143           
  Misses       5051     5051           
Flag Coverage Δ
wasm-lib 86.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierremtb pierremtb enabled auto-merge (squash) February 27, 2025 20:11
@pierremtb pierremtb merged commit 850c5c6 into main Feb 27, 2025
39 of 40 checks passed
@pierremtb pierremtb deleted the franknoirot/4719/fix-kcl-input-overflow branch February 27, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle overflowing text in command palette's KCL argument type input
2 participants