Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the rust version of settings #5563

Merged
merged 4 commits into from
Feb 28, 2025
Merged

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Feb 27, 2025

this will allow us to actually do #2230 after a few versions

we were not saving the backwards compatible format, this has been true ever since we removed tauri because there was some special shit there

going to be making a set of smaller prs w changes from #4919 this is the first one

@jessfraz jessfraz requested a review from nadr0 February 27, 2025 22:52
Copy link

qa-wolf bot commented Feb 27, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app 🛑 Canceled (Inspect) Feb 27, 2025 11:17pm

@jessfraz jessfraz requested a review from lf94 February 27, 2025 22:52
Signed-off-by: Jess Frazelle <[email protected]>
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.42%. Comparing base (5ce22e2) to head (bf01f22).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5563   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files          97       97           
  Lines       37224    37224           
=======================================
  Hits        32169    32169           
  Misses       5055     5055           
Flag Coverage Δ
wasm-lib 86.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz merged commit a0924bc into main Feb 28, 2025
49 of 50 checks passed
@jessfraz jessfraz deleted the save-the-rust-version-of-settings branch February 28, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants