properly flush batch #5565
properly flush batch #5565
Conversation
Signed-off-by: Jess Frazelle <[email protected]>
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5565 +/- ##
==========================================
- Coverage 86.43% 86.38% -0.06%
==========================================
Files 97 97
Lines 37224 37244 +20
==========================================
- Hits 32176 32174 -2
- Misses 5048 5070 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| // Flush the batch with all the end commands. | ||
| // If we don't do this then some programs might not fully finish executing. | ||
| self.engine | ||
| .flush_batch(true, SourceRange::default()) |
There was a problem hiding this comment.
Pretty sure this needs to be inside execute_and_build_graph() so that any commands are captured in the artifact graph.
There was a problem hiding this comment.
oh hey thats. how i can test it!
There was a problem hiding this comment.
will do tomorrow my brain is fried today
we saw in kcl.py that programs were not finsihing executing when in kcl.py
i can test this in this PR #5553 but like waiting on an engine side thing so either you can wait to merge or whatever i did a temp fix in kcl.py in the interim
i cant test this w a snapshot since we will zoom to fit on it flushing the batch anyways