Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make code dryer, #5566

Merged
merged 1 commit into from
Feb 28, 2025
Merged

make code dryer, #5566

merged 1 commit into from
Feb 28, 2025

Conversation

jessfraz
Copy link
Contributor

inner_run used to be recursive i didnt realize it changed, i didnt want this call to be recursive

@jessfraz jessfraz requested a review from nrc February 28, 2025 02:00
Copy link

qa-wolf bot commented Feb 28, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 28, 2025 2:12am

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (a0924bc) to head (42855e3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5566      +/-   ##
==========================================
- Coverage   86.43%   86.41%   -0.02%     
==========================================
  Files          97       97              
  Lines       37224    37222       -2     
==========================================
- Hits        32176    32167       -9     
- Misses       5048     5055       +7     
Flag Coverage Δ
wasm-lib 86.41% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz merged commit 687ef14 into main Feb 28, 2025
36 of 37 checks passed
@jessfraz jessfraz deleted the dry-some-shit branch February 28, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants