Define endpoint in definition.toZigbee containing key 'state' #8190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow the selection of the proper converter with multi endpoints divice at zigbee2mqtt-master\lib\extension\publish.ts at line "const converter = converters.find...c.endpoint == endpointName" This change corrects issue Koenkk/zigbee2mqtt#24352
Koenkk
reviewed
Oct 27, 2024
Koenkk
reviewed
Oct 29, 2024
|
Thanks! |
Koenkk
added a commit
to Koenkk/zigbee2mqtt
that referenced
this pull request
Nov 2, 2024
* `endpoint` in definition.toZigbee can be an array of string To allow the selection of the proper converter with multi endpoints divice This change corrects issue #24352 This change is linked to PR Koenkk/zigbee-herdsman-converters#8190 * Simplify Tz.Converter.endpoints type to string[] array only In zigbee-herdsman-converters\src\lib\types.ts * Update publish.ts --------- Co-authored-by: Koen Kanters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this change is described in issue #24352 (repo: zigbee2mqtt)
This fix allows the selection of the proper converter among others using the same key
statewith multi endpoints device when sending a command state at zigbee2mqtt\lib\extension\publish.ts at line 262const converter = converters.find((c) => (!c.key || c.key.includes(key)) && (!c.endpoint || c.endpoint == endpointName));