1.update comment

Kong · Mar 7, 2025 · ba01468 · ba01468
1 parent 99b69c1
commit ba01468
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/insomnia-smoke-test/playwright/test.ts b/packages/insomnia-smoke-test/playwright/test.ts
@@ -133,7 +133,8 @@ export const test = baseTest.extend<{
       // set testFailed to true if the test timed out or failed
       testFailed = testFailed || testInfo.status === 'timedOut' || testInfo.status === 'failed';
       if (traceMode === 'on' || (traceMode === 'retain-on-failure' && testFailed) || (traceMode === 'on-first-retry' && testInfo.retry === 1)) {
-        // Set tracing file name with the test status
+        // Use a different name rather than the default trace.zip to avoid overwriting the trace.
+        // Refer: https://github.com/microsoft/playwright/issues/35005
         await appContext.tracing.stop({
           path: path.join(testInfo.outputDir, `trace-${testInfo.title}-${testInfo.status}.zip`),
         });

diff --git a/packages/insomnia-smoke-test/tests/smoke/insomnia-vault.test.ts b/packages/insomnia-smoke-test/tests/smoke/insomnia-vault.test.ts
@@ -162,8 +162,6 @@ test.describe('Check vault used in environment', async () => {
     await page.getByRole('option', { name: 'New Environment' }).click();
     await page.getByText('Base Environment1').click();
     await page.getByTestId('underlay').click();
-    // ensure environment is activated
-    await page.waitForTimeout(1000);
     // activate request
     await page.getByTestId('normal').getByLabel('GET normal', { exact: true }).click();
     await page.getByRole('button', { name: 'Send' }).click();