Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Auto detect updated file encoding and read file with encoding[INS-5017] #8428

Merged
merged 6 commits into from
Mar 6, 2025

Conversation

cwangsmv
Copy link
Contributor

@cwangsmv cwangsmv commented Feb 27, 2025

Changes:

  • Move read file from render process to main process, adding the file encoding detection logic.
  • Implement a file encoding picker component for user to select different coding to parse file.
Screenshot 2025-02-27 at 17 14 35 Screenshot 2025-02-28 at 11 13 06

@cwangsmv cwangsmv requested a review from ihexxa February 27, 2025 10:10
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, I was wondering when we were going to need more encodings when I was working on this #8311

@cwangsmv
Copy link
Contributor Author

cwangsmv commented Mar 4, 2025

This is cool, I was wondering when we were going to need more encodings when I was working on this #8311

If we need to support more encodings, I would suggest using iconv-lite rather than the Nodejs built-in Buffer.toString or fs readFile method since iconv-lite supports a wide range of encodings

@cwangsmv cwangsmv force-pushed the fix/runner-upload-file-encoding-issue branch 2 times, most recently from 3ffea29 to e481dd3 Compare March 5, 2025 06:25
@cwangsmv cwangsmv force-pushed the fix/runner-upload-file-encoding-issue branch from e481dd3 to ee5bd04 Compare March 6, 2025 01:46
@cwangsmv cwangsmv enabled auto-merge (squash) March 6, 2025 01:48
@cwangsmv cwangsmv merged commit 114071a into develop Mar 6, 2025
9 checks passed
@cwangsmv cwangsmv deleted the fix/runner-upload-file-encoding-issue branch March 6, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants