Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set native menus per-window #8444

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Stedoss
Copy link

@Stedoss Stedoss commented Mar 9, 2025

Previously when a new window was created Menu.setApplicationMenu() was called, which would change all windows' native menu to the newly created one - causing every window menu to reference the newly created BrowserWindow. This causes weird behaviour with old windows (see Before video).

Now each window is set their own Menu instance which will have their own BrowserWindow.

Note

This mostly impacts Windows and Linux, may need some testing on Mac to make sure behaviour is still as expected.

Before

electron_yApfFkBxZg.mp4

After

iPiHNTZGTX.mp4

Previously when a new window was created `Menu.setApplicationMenu()` was
called, which would change all windows' native menu to the newly created
one - causing every window menu to reference the newly created
`BrowserWindow`.

Now each window is set their own `Menu` instance which will have their
own `BrowserWindow`.
@CLAassistant
Copy link

CLAassistant commented Mar 9, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants