Solutions Chapter 1 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrom911
approved these changes
Oct 18, 2020
| -- DON'T FORGET TO SPECIFY THE TYPE IN HERE | ||
| lastDigit n = error "lastDigit: Not implemented!" | ||
| lastDigit :: Integral n => n -> n | ||
| lastDigit = (`mod` 10) . abs |
There was a problem hiding this comment.
Yes, that's elegant. However, to me the alternative with explicit arguments is sometimes easier to grasp than the point free one, especially when infix notation is used.
I guess to a certain degree it will get better if I get used to it, but probably it makes sense to not use point free style sometimes
Co-authored-by: Veronika Romashkina <[email protected]>
* Avoid name clashing with `last` from Prelude * use `divMod`
Co-authored-by: Veronika Romashkina <[email protected]>
|
Thank you for your detailed feedback! |
|
No problems, @L7R7 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solutions for Chapter 1
cc @vrom911 @chshersh
Since I already know Haskell, some of the solutions are different than what one would expect from a beginner. Looking forward to receiving your feedback!