Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overall cleanup as suggested by clang-tidy :) #197

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Overall cleanup as suggested by clang-tidy :) #197

merged 3 commits into from
Feb 4, 2025

Conversation

christianparpart
Copy link
Member

@christianparpart christianparpart commented Feb 2, 2025 •
edited
Loading

btw, we still fail, because std::expected<> is not available on Github actions's clang-tidy (why?)

@christianparpart christianparpart requested a review from a team February 2, 2025 20:32
@christianparpart christianparpart self-assigned this Feb 2, 2025
@christianparpart christianparpart marked this pull request as draft February 2, 2025 21:01
@christianparpart christianparpart force-pushed the improvement/clang-tidy branch 3 times, most recently from 87105b2 to 85f1554 Compare February 3, 2025 08:10
@christianparpart christianparpart force-pushed the improvement/clang-tidy branch 2 times, most recently from c265d0a to 1dd8497 Compare February 4, 2025 09:07
@Yaraslaut
Copy link
Member

Lets update compiler as well, now we are using clang-18

@christianparpart
tweak build.yml for clang-tidy again
b570329 
Signed-off-by: Christian Parpart <[email protected]>
@christianparpart christianparpart marked this pull request as ready for review February 4, 2025 09:57
Yaraslaut
Yaraslaut approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks :)

@Yaraslaut Yaraslaut merged commit 7c2bde0 into master Feb 4, 2025
12 checks passed
@Yaraslaut Yaraslaut deleted the improvement/clang-tidy branch February 4, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yaraslaut Yaraslaut Yaraslaut approved these changes

Assignees

@christianparpart christianparpart

Labels
benchmark CI pipeline CLI command line interface tools Core API ddl2cpp Query Builder tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianparpart @Yaraslaut