Switch to slf4j

[xxDark]

Title
I wonder if it is possible to get rid of log4j dependency, so the project can be used more easily.

[rcx]

I will look at this tomorrow. Thanks for your contribution

…

On Mon, Jan 3, 2022 at 20:42 xxDark ***@***.***> wrote: Title I wonder if it is possible to get rid of log4j dependency, so the project can be used more easily. ------------------------------ You can view, comment on, or merge this pull request online at: #2 Commit Summary - 6afa384 <6afa384> Switch to slf4j File Changes (11 files <https://github.com/LLVM-but-worse/maple-ir/pull/2/files>) - *M* org.mapleir.app-services/src/main/java/org/mapleir/app/service/ClassTree.java <https://github.com/LLVM-but-worse/maple-ir/pull/2/files#diff-85a6849d5f555e43ead336e5eb660442f1abdaa5999b258ceb837ba84d9ec404> (5) - *M* org.mapleir.app-services/src/main/java/org/mapleir/app/service/InstalledRuntimeClassSource.java <https://github.com/LLVM-but-worse/maple-ir/pull/2/files#diff-fcf20a490d01de1fb5506df93cf8a69530578addf7f5ae3925a339bde1bb36bb> (8) - *M* org.mapleir.ir/src/main/java/org/mapleir/ir/cfg/builder/ControlFlowGraphBuilder.java <https://github.com/LLVM-but-worse/maple-ir/pull/2/files#diff-1eee15f482ecdcd164292f5d9a6648d0243fac94e55fc42725968543bbb7ed3a> (8) - *M* org.mapleir.main/src/main/java/org/mapleir/Boot.java <https://github.com/LLVM-but-worse/maple-ir/pull/2/files#diff-4ddb19a08c8b784690e06a502ee0a6a2e3b25608912976822b3fbdb20d5ee0d1> (5) - *M* org.mapleir.main/src/main/java/org/mapleir/Boot2.java <https://github.com/LLVM-but-worse/maple-ir/pull/2/files#diff-c8d9061f37b5e8c30cf7d54abb9d2454d831b4c565c150caa15e02c75f6958ef> (5) - *M* org.mapleir.main/src/main/java/org/mapleir/DataFlowDemoBoot.java <https://github.com/LLVM-but-worse/maple-ir/pull/2/files#diff-38fb8d91cf1ca95152f8cd0fd710598a248fc8dec0d9174375410fe698247963> (5) - *M* org.mapleir.main/src/main/java/org/mapleir/DefaultInvocationResolver.java <https://github.com/LLVM-but-worse/maple-ir/pull/2/files#diff-b77feacdbb9377b77f96ff1f9fa5c7531ca52388decef5f702d4e03a374c5edd> (5) - *M* org.mapleir.main/src/main/java/org/mapleir/deob/interproc/IRCallTracer.java <https://github.com/LLVM-but-worse/maple-ir/pull/2/files#diff-01f2dbaf8a2c0b68add23c93383703443ac80e65806a28b4ce66c8eb4c1c29ac> (5) - *D* org.mapleir.main/src/main/resources/log4j.properties <https://github.com/LLVM-but-worse/maple-ir/pull/2/files#diff-d87a27585bbd69313fd4f31279716749f94483d3bf63e1a2ca9d33a53d53e9c0> (23) - *M* org.mapleir.parent/pom.xml <https://github.com/LLVM-but-worse/maple-ir/pull/2/files#diff-b4d49194e1132d5fe05b8a3f23ed2b01a26f560a6edc344f187980eb520dcd66> (6) - *M* org.mapleir.service-framework.impl/src/main/java/org/mapleir/serviceframework/impl/ServiceRegistryImpl.java <https://github.com/LLVM-but-worse/maple-ir/pull/2/files#diff-ed8e2644bd5c61bb6839dcf4cce3572a68009292b10c7b75c9c9ac74aa521ad3> (5) Patch Links: - https://github.com/LLVM-but-worse/maple-ir/pull/2.patch - https://github.com/LLVM-but-worse/maple-ir/pull/2.diff — Reply to this email directly, view it on GitHub <#2>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD5NBPL3NIECNN6J7Q7WVEDUUJGA5ANCNFSM5LGLPRUA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[terminalsin]

Pretty sure there’s more changes required as the logger is used quite literally everywhere

[xxDark]

Pretty sure there’s more changes required as the logger is used quite literally everywhere

I'm using this branch locally, and it works fine.
upd: just checked, no log4j references were found

[terminalsin]

Will check how the output looks during the weekend

[terminalsin]

Current branch has no implementation, causing the logger to fallback to… nothing. It's best to stick with Log4j as of now (Legacy is unaffected and if it happens to be in any case scenario, we'll just upgrade to latest)

[xxDark]

It is up to the user to select the implementation. So, to whoever uses this library & however writes an application. That is really the whole point. The library itself should not bundle any implementation.

[terminalsin]

It is up to the user to select the implementation. So, to whoever uses this library & however writes an application. That is really the whole point. The library itself should not bundle any implementation.

I see. Alright here's what I think is best to do: push usage of SLF4j in the parent context and add a Log4j implementation in the main package. I'll make the changes asap