Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PWA Support #115

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add PWA Support #115

wants to merge 2 commits into from

Conversation

FelixBurkhard
Copy link

Add PWA support to be able to install the App like a native App into Windows/iOS/Android.
I followed these instructions

@LXBdev LXBdev added the deploy deploy to environment label Oct 27, 2024
LXBdev
LXBdev requested changes Oct 27, 2024
View reviewed changes
Copy link
Owner

@LXBdev LXBdev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting CORS errors for the webmanifest.

xxx/manifest.webmanifest') from origin 'xxx' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

OpenAIChatGPTBlazor/wwwroot/service-worker.published.js
@@ -0,0 +1,55 @@
// Caution! Be sure you understand the caveats before publishing an application with
// offline support. See https://aka.ms/blazor-offline-considerations
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider/test the impact of these settings and offline mode?

OpenAIChatGPTBlazor/OpenAIChatGPTBlazor.csproj

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<UserSecretsId>a9111ff4-d5fb-46b5-9450-c68be5805382</UserSecretsId>
<DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
<ServiceWorkerAssetsManifest>service-worker-assets.js</ServiceWorkerAssetsManifest>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: identation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LXBdev LXBdev LXBdev requested changes

Assignees
No one assigned
Labels
deploy deploy to environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FelixBurkhard @LXBdev