Do deep sort instead of shallow sort. Allow sort.js to be run without… #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtrom
reviewed
Nov 28, 2019
sort.js
Outdated
| // E.g. reordering questions-api.json's characterMapCharacters would | ||
| // cause the special characters to appear in a different order in | ||
| // the product. | ||
| if (val && !Array.isArray(val) && typeof val === 'object') { |
There was a problem hiding this comment.
Do you need the !Array.isArray(val) here? Or are arrays objects in JS? If so, I'd swap the Array.isArray and the typeof
There was a problem hiding this comment.
@shtrom welcome to typeof confusion land :)
There was a problem hiding this comment.
Yep, arrays are considered objects in JS. I'll swap the two then.
shtrom
approved these changes
Nov 28, 2019
michal-huzevka
force-pushed
the
improve-sort-labels
branch
from
a525fe2 to
54228ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… any arguments