This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FEATURE] Add onload event to init Items API properly
- Loading branch information
Dmitry Kochnev
committed
Dec 4, 2018
1 parent
2d4f50a
commit d22f638
Showing
2 changed files
with
19 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,13 @@ | ||
| <script> | ||
| window.learnosityCollection = window.learnosityCollection || []; | ||
| window.learnosityCollection.push(LearnosityItems.init(<?php echo $signed_request; ?>, { errorListener: function(e) { console.log(e); } })); | ||
| // WP can add "defer" flag to <script> inside "wp_enqueue_script" function | ||
| // it might lead to the error that "LearnosityItems" below in undefined | ||
| // to protect against it, we will use "load" global event to secure that all JS assets are loaded before calling any JS code | ||
| window.addEventListener("load", function () { | ||
| window.learnosityCollection = window.learnosityCollection || []; | ||
| window.learnosityCollection.push(LearnosityItems.init(<?php echo $signed_request; ?>, { | ||
| errorListener: function (e) { | ||
| console.log(e); | ||
| } | ||
| })); | ||
| }); | ||
| </script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,13 @@ | ||
| <script> | ||
| // WP can add "defer" flag to <script> inside "wp_enqueue_script" function | ||
| // it might lead to the error that "LearnosityReports" below in undefined | ||
| // to protect against it, we will use "load" global event to secure that all JS assets are loaded before calling any JS code | ||
| window.addEventListener("load", function () { | ||
| window.learnosityCollection = window.learnosityCollection || []; | ||
| window.learnosityCollection.push(LearnosityReports.init(<?php echo $signed_request; ?>, { errorListener: function(e) { console.log(e); } })); | ||
| window.learnosityCollection.push(LearnosityReports.init(<?php echo $signed_request; ?>, { | ||
| errorListener: function (e) { | ||
| console.log(e); | ||
| } | ||
| })); | ||
| }); | ||
| </script> |