Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support/swap automation demo3 #8110

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Support/swap automation demo3 #8110

wants to merge 18 commits into from
+164 −77

Conversation

bharamboure-ledger
Copy link
Contributor

@bharamboure-ledger bharamboure-ledger commented Oct 15, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests. actually automated tests
  • Impact of the changes:
    • ...

📝 Description

Swap e2e flows adapted to demo3 env

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 2:29pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 2:29pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 2:29pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 2:29pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 2:29pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Oct 15, 2024
@bharamboure-ledger bharamboure-ledger force-pushed the support/swap-automation-demo3 branch 3 times, most recently from 7ae3293 to a4a3792 Compare October 15, 2024 18:05
@bharamboure-ledger bharamboure-ledger requested a review from a team as a code owner October 17, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@gbecerra-ledger gbecerra-ledger Awaiting requested review from gbecerra-ledger

@stual-ledger stual-ledger Awaiting requested review from stual-ledger

At least 1 approving review is required to merge this pull request.

Assignees

@bharamboure-ledger bharamboure-ledger

Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bharamboure-ledger @ypolishchuk-ledger