Skip to content

Commit

Permalink
fix mypy issues
Browse files Browse the repository at this point in the history
  • Loading branch information
Leggin committed Apr 5, 2024
1 parent ff1ac73 commit a320fec
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/dirigera/hub/hub.py
Original file line number Diff line number Diff line change
Expand Up @@ -373,15 +373,15 @@ def create_scene(
"triggers": trigger_list,
"actions": action_list,
}
data = camelize_dict(data)
data = camelize_dict(data) # type: ignore
response_dict = self.post(
"/scenes/",
data=data,
)
scene_id = response_dict["id"]
return self.get_scene_by_id(scene_id)

def delete_scene(self, scene_id: str):
def delete_scene(self, scene_id: str) -> None:
self.delete(
f"/scenes/{scene_id}",
)
6 changes: 4 additions & 2 deletions src/dirigera/hub/utils.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import functools
import re
from typing import Dict, List, Union
from typing import Any, Dict, List, Union


def camelize_dict(data: Union[Dict, List]) -> Dict:
def camelize_dict(
data: Union[Dict[str, Any], List[Any]]
) -> Union[Dict[str, Any], List[Any]]:
camelize = functools.partial(re.sub, r"_([a-z])", lambda m: m.group(1).upper())

if isinstance(data, list):
Expand Down
4 changes: 3 additions & 1 deletion tests/test_utils.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from src.dirigera.hub.utils import camelize_dict


def test_camelize_dict():
def test_camelize_dict() -> None:
data = {
"key_a": "data_b",
"key_b": {
Expand All @@ -11,9 +11,11 @@ def test_camelize_dict():
}
result = camelize_dict(data)
assert "keyA" in result
assert isinstance(result, dict)
assert result["keyA"] == data["key_a"]
assert "keyB" in result
assert "keyBA" in result["keyB"]
assert isinstance(data["key_b"], dict)
assert result["keyB"]["keyBA"] == data["key_b"]["key_b_a"]
assert "keyBBA" in result["keyB"]["keyBB"]
assert result["keyB"]["keyBB"]["keyBBA"] == data["key_b"]["key_b_b"]["key_b_b_a"]
Expand Down

0 comments on commit a320fec

Please sign in to comment.